Re: RFS: tkgate (updated package)
On Wed, Apr 23, 2008 at 04:04:03PM +0200, Alexander Schmehl wrote:
> A couple of "should be fixed" I noticed while looking at your diff.gz:
>
> - You removed stuff from the orig.tar.gz, so you should rename the
> tarball, too. E.g. to tkgate_2.0.dfsg.1~a11-1.orig.tar.gz
> - A "get-orig-source" rule would be nice
> - You build depend on debhelper >= 6..., but your debian/compat is set to 5. I
> think that's wrong, since you either should set debian/compat to 6 or
> don't need to build depends in debhelper >= 6.
> (Somebody please correct me, if that's untrue; I'm not entirely sure.)
>
> Oh, and you should have retitled the bug to "RFA" to indicate, that you
> want to adopt the package and set the owner of the bug report to
> yourself.
---end quoted text---
Thanks, fixing those now.
--
أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
SySDSoft, Inc.
GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net)
GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27
Reply to: