[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libnotifymm



在 2008-04-21一的 00:03 +0200,Helmut Grohne写道:
> > * Package name    : libnotifymm
> 
> Two minor comments:
> 
> 1) Your copyright file is inconsistent about the gpl versions. You
>    mention L?GPL-2+ whereas the path to /usr/share/common-licenses
>    points to a version 3.
> 

Fixed.  And there's a complication that the COPYING file in the source
is of LGPL version 2.1, while all the file headers are of version 2.  I
believe the file headers are out-of-date.  Will contact upstream to
update them.

> 2) Few people use control.in and those who do mostly do so for good
>    reasons. I think the only feature used here is the @GNOME_TEAM@
>    macro. It might be a good idea to not use control.in in order to
>    reduce complexity unless the gnome team advises you to do so.
> 

Besides the @GNOME_TEAM@ macro, there are more utility used.  As
libnotifymm is a GNOME module, it'll merit more from gnome-pkg-tools,
such as get-orig-source etc.

Thanks for the comments, and the updated new version has been uploaded.
Please recheck.  Thanks

> Helmut
> 
> 
-- 
Regards,
Deng Xiyue, a.k.a. manphiz



Reply to: