[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: xiterm+thai

On Feb 19, 2008 2:44 AM, Neutron Soutmun <neo.neutron@gmail.com> wrote:

> - - dget
> http://mentors.debian.net/debian/pool/main/x/xiterm+thai/xiterm+thai_1.07-1.dsc

Some comments:

Unless you need new features of debhelper compat 6, please leave it at
the latest compat level available in stable.

Description suggestion:

Description: X terminal program with Thai languague support
 xiterm+thai is an X terminal emulator program with Thai language
 support. It has built-in Thai keyboard input support. You could
 also use the X11 XKB extension to input Thai characters.
 A Thai font is needed to display Thai characters.

Probably don't need README installed since it is about building, I'm
guessing README.thai too. Same for COPYRIGHT.HISTORY (copied in
debian/copyright), doc/README.rxvt.greek - Thai != greek :), and maybe
the README.xvt too.

Perhaps README.thai should be reencoded in UTF-8?

What is the reason for having two entries in the menu file? Also, it
would be good to add a desktop file to support GNOME since by default
it now doesn't show the Debian menu IIRC.

The README.Debian needs to be checked and maybe rewritten.

txiterm manual page:

This isn't really needed "This manual page documents briefly the
txiterm command".

OPTIONS section needs filling out.

Very nice changelog entry, good work on the package :)

Shame the package got removed, thanks for working on getting it back in.



Reply to: