On lun, 2007-12-10 at 11:35 -0600, Luis Rodrigo Gallardo Cruz wrote:
> On Mon, Dec 10, 2007 at 06:25:34PM +0100, Carlos Martín Nieto wrote:
> >
> > On dom, 2007-12-09 at 16:52 -0600, Luis Rodrigo Gallardo Cruz wrote:
> > > > You can find it at http://www.cmartin.tk/blam/blam_1.8.4-3.dsc
> > >
> > > I will review your package for upload. It will take a little while,
> > > since you will be my first sponsoree. Please be patient.
> >
> > Thanks, I'll try to backport a few fixes from the dev version
> > meanwhile.
>
> I had a first look through the package. Several of the debian patches
> look like they belong upstream. Since you're him ;) Is there a reason
> they have not been included?
Indeed there is. Those patches were made after the 1.8.4 version was
released and there isn't going to be a 1.8.5 version (well, that was the
plan, I may yet release it) those patches end up in Debian. They are
upstream, just in a later version.
>
> Also, some changes from -2.1 to -3 are patches to upstream but are not
> in a separate patch but included in the .diff.gz Please separate them.
I've just noticed the patch to blam.desktop.in.in, which I'll separate.
I think the reason Makefile.{am,in} are patched directly is because the
patches are applied too late in the process and by then the Makefile has
already been created.
This seems like it shouldn't be the case so I'll try again, but I do
remember trying to put the Makefile.{am,in} changes in a patch and not
being able to.
cmn
--
Carlos Martín Nieto | http://www.cmartin.tk
Hobbyist programmer |
Attachment:
signature.asc
Description: This is a digitally signed message part