[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gnome-color-chooser



On Nov 26, 2007 8:30 AM, JackTheDipper
<gnome-color-chooser@punk-ass-bitch.org> wrote:

> I just uploaded the newest upstream version and tried to fulfill the
> debian policy.
> It's now pbuilder and lintian clean.

Errrr, I guess the diff.gz is empty because you are upstream? Can I
suggest that you put the debian/ directory in the diff.gz instead of
your upstream tarball?

Anyway, onto the review:

You didn't file an ITP bug and close it in the changelog, please read
http://www.debian.org/devel/wnpp/#l1

Please move the homepage to a proper field:
http://wiki.debian.org/HomepageFieldHOWTO

debian/copyright points to /usr/share/common-licenses/GPL, which is a
symlink to GPL-3, and your package seems to be GPL-2 or later.

Please remove cruft from debian/rules and debian/watch that isn't
needed or used.

Might want to install NEWS, THANKS using dh_installdocs

-- 
bye,
pabs

http://wiki.debian.org/PaulWise



Reply to: