hi harish, > Thanks for the review and the helpful feedback. > I have fixed the autopkgtest PID handling and removed Priority > optional and Rules Requires Root from d/control as > suggested. The updated changes are pushed to Salsa. Please re > review the changes. Thanks, I see the script captures properly the dicomscope process and I believe it is all good. When reviewing the package, I inially ran into a complaint from the autopkgtest wrapper, that had to carry extra cleanup steps: autopkgtest [21:05:03]: test run-unit-test: [----------------------- xvfb-run --auto-servernum "/usr/bin/$bin" "$TESTFILE" 2>&1 & sleep 30 starting DICOMscope please wait... check_n_cleanup /tmp/autopkgtest.nQILB8/wrapper.sh: Killing leaked background processes: 21 PID TTY STAT TIME COMMAND 21 ? Z 0:00 [xvfb-run] <defunct> autopkgtest [21:05:33]: test run-unit-test: -----------------------] But after further investigation, it seems relatively harmless: I'm under the impression that Xvfb and dicomscope take some time to teardown, which results in xvfb-run being still referenced in the table of processes while waiting for their error codes. This does not occur in every autopkgtest runs. I believe that you don't need further action to address it. > One quick question, since this is a packaging only change, > should I add a changelog entry using dch or leave the > changelog unchanged. Yes, because the purpose of the d/changelog is to document the changes that have been introduced by each package version uploaded to the archive. It also technically encodes the package version and target distribution, so there needs to be new entry on top of the older ones for a valid upload. Each follow up iteration of the package increments the trailing revision, so yours should be 3.6.0-29. [1]: https://www.debian.org/doc/debian-policy/ch-source.html#debian-changelog-debian-changelog Have a nice day, :) -- .''`. Étienne Mollier <emollier@debian.org> : :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/pts/1, please excuse my verbosity `- on air: Rush - The Spirit of Radio
Attachment:
signature.asc
Description: PGP signature