Hi Harish, Le 01/06/2025 à 13:21, harish chavre a écrit :
Hi Pierre , Thank you for reviewing the autopkgtest I added for the king package.
You're welcome :)
Regarding the suggestion to replace the command |java -jar /usr/share/ java/king.jar | with |/usr/bin/king|, I checked the situation. The |/ usr/bin/king| path is currently just a symlink to |/usr/share/java/ king.jar|. Since this is a Java Archive file and not an executable, it cannot be run directly. Trying to execute |/usr/bin/king| gives an error that says it could not find an interpreter, because there is no wrapper script or binary to handle it.
You're right, this is wrong and I opened bug #1107114 about this, with the suggestion of a fix. If you are comfortable with it, it would be welcome to have you address it :)
Then you may invoke just ``king'' in your autopkgtest.
Regarding the restriction marked as "superficial," I understand that removing it would allow for a more complete test. However, king is a graphical application that requires X11 to work, and running the test without a virtual display setup causes errors because it tries to open a window. In my setup, I am running the test inside a schroot environment, which does not provide display authorization, so the test cannot access the X11 display.Could you please suggest how I should proceed?
I perfectly understand. My concern is that your test is, still, powerful, and having only a superficial test would not result in a migrating bounty. Sure, this is still better than having no test.
I suggest you consider whether your test covers a significant part of the functionality of king. ``a significant part'' is not ``everything''. If you think it does, then the superficial restriction may be removed. Else keep it and this is still good to have :)
I will verify the license of example.kin and update debian/copyright accordingly.
Thanks for this, and for all the work also.
Regards, Harish Cheers,
-- Pierre
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature