Re: Request for review:added autopkgtest for king

Hi Pierre ,

Thank you for reviewing the autopkgtest I added for the king package.

Regarding the suggestion to replace the command java -jar /usr/share/java/king.jar with /usr/bin/king, I checked the situation. The /usr/bin/king path is currently just a symlink to /usr/share/java/king.jar. Since this is a Java Archive file and not an executable, it cannot be run directly. Trying to execute /usr/bin/king gives an error that says it could not find an interpreter, because there is no wrapper script or binary to handle it.

Regarding the restriction marked as "superficial," I understand that removing it would allow for a more complete test. However, king is a graphical application that requires X11 to work, and running the test without a virtual display setup causes errors because it tries to open a window. In my setup, I am running the test inside a schroot environment, which does not provide display authorization, so the test cannot access the X11 display.

Could you please suggest how I should proceed?

I will verify the license of example.kin and update debian/copyright accordingly.

On Sunday, 1 June, 2025 at 02:10:08 am IST, Pierre Gruet <pgt@debian.org> wrote:

Hello Harish,

Le 29/05/2025 à 21:34, harish chavre a écrit :
> Hi Team,
>
> i have added autopkgtest for package king [0].
> kindly review and share your feedback.

Thanks a lot for improving the king package!

I am quite confident the ``superficial'' restriction can be removed: a
classic king input file is read and treated, also the test invokes java,
which supposes the command line is correctly read...
You could try to invoke ``king'' instead of ``java -jar
/usr/share/java/king.jar'' to also test the file we ship in /usr/bin.

But what about the license of the example.kin file you shipped in
debian/tests? Certainly this should be clarified and then the package
will be fit IMO.

>
> [0] https://salsa.debian.org/med-team/king/-/tree/master/debian/tests?
> ref_type=heads <https://salsa.debian.org/med-team/king/-/tree/master/

> debian/tests?ref_type=heads>
>
> Regards,
> Harish

>

All the best,

--
Pierre