[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for review:added autopkgtest for king



Hello Harish,

Le 29/05/2025 à 21:34, harish chavre a écrit :
Hi Team,

i have added autopkgtest  for package king [0].
kindly review and share your feedback.

Thanks a lot for improving the king package!

I am quite confident the ``superficial'' restriction can be removed: a classic king input file is read and treated, also the test invokes java, which supposes the command line is correctly read... You could try to invoke ``king'' instead of ``java -jar /usr/share/java/king.jar'' to also test the file we ship in /usr/bin.

But what about the license of the example.kin file you shipped in debian/tests? Certainly this should be clarified and then the package will be fit IMO.


[0] https://salsa.debian.org/med-team/king/-/tree/master/debian/tests? ref_type=heads <https://salsa.debian.org/med-team/king/-/tree/master/ debian/tests?ref_type=heads>

Regards,
Harish


All the best,

--
Pierre

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: