Hi Sébastien, Sébastien Jodogne, on 2022-04-26: > I've just created a new package that brings support for neuroimaging in > Orthanc (DICOM-to-NIfTI conversion, similarly to dcm2niix): > https://salsa.debian.org/med-team/orthanc-neuro/ > > Would it be possible for a Debian developer to review this package, and > possibly upload it to NEW? Many thanks in advance! I had a quick look at your new package and I have few remarks. d/watch: I would have bumped it to version=4; from quick check, this seems to be doable without further change to the file. d/copyright: I expect ftpmaster to raise eyebrows on the following files under LGPL-3+ but not documented as such: Resources/Orthanc/CMake/AutoGeneratedCode.cmake Resources/Orthanc/CMake/Compiler.cmake Resources/Orthanc/CMake/DownloadOrthancFramework.cmake Resources/Orthanc/CMake/DownloadPackage.cmake Resources/Orthanc/CMake/EmbedResources.py Resources/Orthanc/CMake/GoogleTestConfiguration.cmake Resources/Orthanc/CMake/WindowsResources.py Resources/Orthanc/Toolchains/LinuxStandardBaseToolchain.cmake Resources/Orthanc/Toolchains/MinGW-W64-Toolchain32.cmake Resources/Orthanc/Toolchains/MinGW-W64-Toolchain64.cmake Resources/Orthanc/Toolchains/MinGWToolchain.cmake I get the package-has-unnecessary-activation-of-ldconfig-trigger lintian warning. I suppose this may be a side effect of a bug in debhelper while auto-generating files from d/triggers, but if you were to have a precise idea of the cause, it would be nice to fix it or clarify the situation in a comment around a lintian override. The package looks otherwise in rather good shape to me. Once the d/copyright file is adjusted, I would be happy to sponsor upload. Thank you for Orthanc developpement! Have a nice day, :) -- Étienne Mollier <emollier@emlwks999.eu> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity.
Attachment:
signature.asc
Description: PGP signature