Thanks for your feedback-- (see inline)
On الخميس 23 تـمـوز 2015 19:50, Ali Ebrahim wrote:
> Hello Afif,
>
> Thank you very much for doing this!
>
No problem.
> I have the following comments for the next version (I'll be releasing
> beta 2 soon, so maybe you can do it when you make an updated package
> for that).
>
Just to make sure we're on the same page, I'm going by definitions of
the suggests/recommends fields at:
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps
> 1) Please remove jython from sug. cobrapy is no longer developed or
> tested on jython.
> 2) Please make the data required, as its necessary for some cobrapy
> functions.
Committed.
> (Also please make sure that cobra.test.data_directory
> contains the test files).
>
I separated the data so they could be shared by the different python
versions of the package, but there is a symlink in the appropriate place
so as not to break the software.
In light of the policy definitions linked above, I was also going to
change matplotlib and pandas from 'recommended' to 'suggested'. Do you
think I should keep them as recommended? Recommended packages get
installed by default.
> Once again, this is awesome.
>
By the way, is there a reason to also package the cobra toolbox or is
that on its way out of use?
Regards
Afif