[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating the fis-gtm package to V6.2-000



Hi Andreas,

On 09/24/14 08:43, Andreas Tille wrote:
Hi Amul,

On Wed, Sep 24, 2014 at 12:25:22AM -0400, Amul Shah wrote:
Hi Andreas,
Thanks to your prior instructions and V6.2-000 changes eliminating the patch series, going through this round was a quite quick.
:-)
I added two lintian warnings overrides. Please let me know if they are correct.
Lintian was able to use the crated overrides - so this is obviously fine.
I just fixed

   W: fis-gtm-6.2-000: debian-changelog-line-too-long line 6

(git pull) - please note that the target distribution should be
"UNRELEASED" until we will release.

[amul:1] Whoops! Thanks for catching that.


I also wonder whether you could forward the "spelling-error-in-binary"
type lintian infos to upstream.

[amul:1] I didn't see this lintian message. That said, cleaning things up in the upstream is preferable. The fewer exceptions the better.



While looking at the installed directory, I noticed two inconsistencies marked as (todo) in the changelog. Both entries are related to the encryption plugins. We build only one plugin (using libgcrypt and AES256CFB) and the "plugin" directory is a symlink in the utf8 directory (which IIRC does not match what our install script produces).
So do you plan to fix this before I'll upload?  Please tell me once you
are happy with the package since I personally know to less about fis-gtm
to know whether these todos are blocking issues or not.

[amul:1] I would like to fix the build to generate all of the encryption plugins, but I don't think that should hold up the release of the V6.2-000.

[amul:1] The "plugin" directory as a symlink is only a problem when using an encrypted database with V6.1-000 and UTF-8. Since we have V6.2-000 almost ready, I don't know if it is worth the time to fix that bug in V6.1-000 package. I'll remove the TODO from the changelog later this evening.


On a loosely related note, I learned how to avoid signing the packages without my GPG key (https://urldefense.proofpoint.com/v1/url?u=http://notes.timeghost.net/2009/12/build-a-binary-deb-package-without-signing.html&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=KgGzFmrpr0CH7A8VRCDGC05IrYOn9XWlNRvgNmiK%2BUg%3D%0A&m=suSYh9PBJI4AnykXR8LT0MXOo4laSsqYvvlWactd2zQ%3D%0A&s=eb46e5a0552dcec80118381e87eda2e691ead9d6001bd2edd592f889d46e1764). You may recall this was my stumbling block for V6.0-003.
   git-buildpackage --git-builder="debuild -i -us -uc"
Yup - I should have mentioned this, sorry.

Kind regards and thanks for your work on this

        Andreas.

[amul:1] No worries. I learned enough looking for the answers to my problems.

thanks, Amul



_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.


Reply to: