Bug#971264: mediawiki: ParseError after 1.27.7-1~deb9u4 upgrade (blame patch for User::pingLimiter)
Package: mediawiki
Version: 1:1.27.7-1~deb9u4
Severity: grave
Justification: renders package unusable
Dear Maintainer,
After the update to 1.27.7-1~deb9u4 (from 1.27.7-1~deb9u3), the mediawiki site
errors in all pages with:
    Exception encountered, of type "ParseError"
Enabling some debug messages, gives a bit more detail:
    Exception encountered, of type "ParseError"
    [a5b5213be767b7723077eae1] /w/ ParseError from line 1813 of /usr/share/mediawiki/includes/user/User.php: syntax error, unexpected 'else' (T_ELSE)
    Backtrace:
    #0 [internal function]: AutoLoader::autoload(string)
    #1 /usr/share/mediawiki/includes/session/SessionBackend.php(125): spl_autoload_call(string)
    #2 /usr/share/mediawiki/includes/session/SessionManager.php(854): MediaWiki\Session\SessionBackend->__construct(MediaWiki\Session\SessionId, MediaWiki\Session\SessionInfo, CachedBagOStuff, MediaWiki\Logger\LegacyLogger, integer)
    #3 /usr/share/mediawiki/includes/session/SessionManager.php(301): MediaWiki\Session\SessionManager->getSessionFromInfo(MediaWiki\Session\SessionInfo, WebRequest)
    #4 /usr/share/mediawiki/includes/session/SessionManager.php(235): MediaWiki\Session\SessionManager->getEmptySessionInternal(WebRequest)
    #5 /usr/share/mediawiki/includes/session/SessionManager.php(185): MediaWiki\Session\SessionManager->getEmptySession(WebRequest)
    #6 /usr/share/mediawiki/includes/WebRequest.php(700): MediaWiki\Session\SessionManager->getSessionForRequest(WebRequest)
    #7 /usr/share/mediawiki/includes/session/SessionManager.php(121): WebRequest->getSession()
    #8 /usr/share/mediawiki/includes/Setup.php(747): MediaWiki\Session\SessionManager::getGlobalSession()
    #9 /usr/share/mediawiki/includes/WebStart.php(137): require_once(string)
    #10 /usr/share/mediawiki/index.php(40): require(string)
    #11 {main}
Looking at User.php lines 1813, the whole thing looks odd.  This comes from the
Debian patch "0009-User-pingLimiter-add-user-global-rate-limit-type.patch"
-- System Information:
Debian Release: 9.13
  APT prefers oldstable
  APT policy: (500, 'oldstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.9.0-13-amd64 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages mediawiki depends on:
ii  apache2 [httpd]                 2.4.25-3+deb9u9
ii  mediawiki-classes               1:1.27.7-1~deb9u4
ii  mime-support                    3.60
ii  php                             1:7.0+49
ii  php-common                      1:49
ii  php-mbstring                    1:7.0+49
ii  php-mysql                       1:7.0+49
ii  php-xml                         1:7.0+49
ii  php7.0 [php]                    7.0.33-0+deb9u9
ii  php7.0-mbstring [php-mbstring]  7.0.33-0+deb9u9
ii  php7.0-mysql [php-mysqlnd]      7.0.33-0+deb9u9
ii  php7.0-xml [php-xml]            7.0.33-0+deb9u9
Versions of packages mediawiki recommends:
ii  mariadb-server-10.1 [virtual-mysql-server]  10.1.45-0+deb9u1
ii  php-curl                                    1:7.0+49
ii  php-intl                                    1:7.0+49
ii  php-wikidiff2                               1.4.1-1
ii  php7.0-cli [php-cli]                        7.0.33-0+deb9u9
ii  php7.0-curl [php-curl]                      7.0.33-0+deb9u9
ii  php7.0-intl [php-intl]                      7.0.33-0+deb9u9
ii  python                                      2.7.13-2
Versions of packages mediawiki suggests:
pn  clamav                           <none>
pn  hhvm                             <none>
ii  imagemagick                      8:6.9.7.4+dfsg-11+deb9u10
ii  imagemagick-6.q16 [imagemagick]  8:6.9.7.4+dfsg-11+deb9u10
ii  memcached                        1.4.33-1+deb9u1
pn  php-apcu                         <none>
-- Configuration Files:
/etc/apache2/conf-available/mediawiki.conf changed [not included]
/etc/mediawiki/mediawiki.conf changed [not included]
-- no debconf information
Reply to: