[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 3/3] report-vuln: Support generation of mail headers



Hi Guido,

On Wed, Nov 29, 2017 at 04:49:41PM +0100, Guido Günther wrote:
> Hi,
> On Wed, Nov 29, 2017 at 04:24:54PM +0100, Salvatore Bonaccorso wrote:
> > Hi Guido,
> > 
> > On Wed, Nov 29, 2017 at 01:48:02PM +0100, Guido Günther wrote:
> > > Address the bts already and put the CVEs in the subject.
> > > 
> > > ---
> > > This can be further improved regards temp id handling, providing a
> > > better subject in case of only a single CVE, etc. but already makes like
> > > simpler. O.k. to apply?
> > 
> > Looks fine as long the -m remains the non-default for now and
> > bin/report-vuln just can be used to generate templates as before.
> 
> Withou '-m' the output is as it was before.

Ack!

> > 
> > Would it be possible though to change the generated subject to include
> > the source package name (or binary package name, depending on the
> > mode) as provided, and append after a : just the CVEs space separated?
> > 
> > That is rather than
> > 
> > Subject: CVE-id1, CVE-id2, ...
> > 
> > more like
> > 
> > Subject: srcpkg: CVE-id1 CVE-id2 ...
> 
> Attached patch does just that.

Looks good to me, so if you don't hear any objection please go ahead
as well with that third change.

Regards,
Salvatore

Attachment: signature.asc
Description: PGP signature


Reply to: