Re: [DEBIAN-LTS] ettercap package
Hello Raphael Hertzog,
I propose to let Nguyen Cong take care of fixing this so that he can
learn about quilt and have some easy entry into contributing to the LTS
team. Nguyen, feel free to get some inspiration from Gianfranco's more
verbose changelog message though. :)
Great. I really appreciate your words. If everyone is OK with this,
I will send the debdiff of ettercap to the list soon.
And I also want to take care of firebird2.1. Is this OK?
Thanks and best regards
Cong
On 24/12/2014 15:01, Raphael Hertzog wrote:
Hello,
On Tue, 23 Dec 2014, Thorsten Alteholz wrote:
On Tue, 23 Dec 2014, Nguyen Cong wrote:
I have created .deb file for ettercap package.
great, thanks alot.
Since I'm not DD or DM so I attached debdiff file for review
as mentioned in LTS/Development wiki page.
Could anyone please check it and tell me if any comments?
After a first glimpse it seems to be that this package uses quilt, but you
directly changed the source files. Please don't change the way of the
original maintainer to handle patches.
It looks like the upstream author made the same mistake when preparing
an upload of his own in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773416#50
I propose to let Nguyen Cong take care of fixing this so that he can
learn about quilt and have some easy entry into contributing to the LTS
team. Nguyen, feel free to get some inspiration from Gianfranco's more
verbose changelog message though. :)
Cheers,
--
=====================================================================
Nguyen The Cong (Mr)
Software Engineer
Toshiba Software Development (Vietnam) Co.,Ltd
519 Kim Ma street, Ba Dinh District, Hanoi, Vietnam
tel: +84-4-2220 8801 (Ext. 208)
e-mail: cong.nguyenthe@toshiba-tsdv.com
=====================================================================
Note: This e-mail message may contain personal information or confidential information. If you are not the addressee of this message, please delete this message and kindly notify the sender as soon as possible - do not copy, use, or disclose this message.
--
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com
Reply to: