Bug#701825: Use xorg driver for multiple display controllers
Daniel Baumann <daniel.baumann@progress-technologies.net> writes:
> retitle 701825 support multi-monitor live-specific xorg configuration
> severity 701825 wishlist
> tag 701825 - patch
> thanks
>
> On 02/27/2013 04:37 PM, Gaudenz Steinlin wrote:
>> This patch is based on the patch in the previously submitted bug report to reconfigure the X server
>> on every boot.
>
> as indicated that first patch will not be applied, so this one shouldn't
> be based on it.
Without the first patch this one is pretty useless. It's then only
relevant if you happen to do the first boot on such a system. Which is
really a corner-case.
>
>> The patch contains some code reorganisation to avoid nesting the if
>> statements even more. Also it's much easier to catch the different cases
>> that require xorg driver autodetection with a subroutine.
>
> please consider submitting such things in two patches, refactoring *and*
> changing functionality together makes review pita.
As long as you don't even consider the other patch I won't bother as the
xorg configuration functionality is useless to me in that case. If there
is a chance that you would consider this I could try to separate this,
but if you looked at the patch you will probably notice that it's not
really easily separateable.
Gaudenz
--
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~
Reply to: