[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694806: Failure with persistence filesystem with old label (live-rw)



Package: live-boot
Version: 3.0~b8
Severity: important
Tags: patch

Booting with a persistence filesystem that has the old "live-rw" label
results in a correct persistence.conf being written to that filesystem but the
filesystem is not used as persistence layer after boot.

This is because when mount_persistence_media is run the filesystem is
already mounted at the right place and this function does not output the
mount point in this case. The attached patch fixes this. With this patch
filesystems with the label "live-rw" work again.

I've also noticed that in the "debian-next" branch the backwards
compatibility for live-rw and home-rw labels is removed. What's the
planned upgrade path with this change? Do you expect users to relabel
their filesystems or do you plan to add code to automatically relabel
filesystems?

Gaudenz

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (800, 'testing'), (700, 'unstable'), (50, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 9fbad43ed1d0a100733ae705ff68de8aa8c1e869 Mon Sep 17 00:00:00 2001
From: Gaudenz Steinlin <gaudenz@debian.org>
Date: Fri, 30 Nov 2012 14:52:08 +0100
Subject: [PATCH] Fix backwards compatibility for persistence

If the persistence medium has one of the backwards compatibility labels
it's already mounted at the correct mount point when
mount_persistence_media is run. This commit fixes this function to output
the mountpoint in this case.
---
 scripts/boot/9990-misc-helpers.sh |    1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/boot/9990-misc-helpers.sh b/scripts/boot/9990-misc-helpers.sh
index ace130b..6eeb9ee 100755
--- a/scripts/boot/9990-misc-helpers.sh
+++ b/scripts/boot/9990-misc-helpers.sh
@@ -761,6 +761,7 @@ mount_persistence_media ()
 			return 1
 		fi
 	fi
+	echo ${backing}
 	return 0
 }
 
-- 
1.7.10.4


Reply to: