[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#640637: marked as done (uses hardcoded errno values)

Your message dated Thu, 05 Apr 2012 21:47:17 +0000
with message-id <[🔎] E1SFuWT-0001Xl-90@franck.debian.org>
and subject line Bug#666991: Removed package(s) from unstable
has caused the Debian Bug report #640637,
regarding uses hardcoded errno values
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
640637: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640637
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: live-magic
Version: 1.14
Severity: normal
Tags: patch

Hi,

currently live-magic compares 'errno' values with hardcoded numeric values,
instead of using the constants of the 'errno' Python module.
This can lead to bugs due to E* values being potentially different per-OS,
and even per-arch for the same OS.

The attached patch fixes the issue.

Thanks,
-- 
Pino

diff --git a/DebianLive/elements/folder_of_files.py b/DebianLive/elements/folder_of_files.py
index d48af4d..0f0bc4e 100644
--- a/DebianLive/elements/folder_of_files.py
+++ b/DebianLive/elements/folder_of_files.py
@@ -18,6 +18,7 @@
 
 import glob
 import os
+import errno
 
 from os.path import join
 
@@ -44,7 +45,7 @@ class FolderOfFiles(dict):
                     f.close()
             except IOError, e:
                 # "Is a directory"
-                if e.errno == 21:
+                if e.errno == errno.EISDIR:
                     continue
 
     def __delitem__(self, k):

--- End Message ---
--- Begin Message --- 
Version: 1.14+rm

Dear submitter,

as the package live-magic has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/666991

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)

--- End Message ---
Reply to: