[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#543259: lintian wrongly reports that a quilt build-dep is necessary



Package: lintian
Version: 2.2.14
Severity: normal
Tags: patch

Hi,

I believe I'm getting a false error from lintian on one of my packages
(http://lintian.debian.org/full/norsetto@ubuntu.com.html#gecko-mediaplayer).
I guess the problem is that lintian doesn't properly consider commented
out dh_quilt_* calls.
This is simply solved by anchoring the regex (quite commonly done in
all other checks AFAICS), like on the attached patch.

Cheers,

Cesare
--- checks/rules~	2009-08-16 07:47:49.000000000 +0200
+++ checks/rules	2009-08-23 18:55:49.000000000 +0200
@@ -89,7 +89,7 @@
      [ "po-debconf" => qr'^\t\s*debconf-updatepo\s' ],
      [ $PYTHON_DEPEND => qr'^\t\s*python\s', 'missing-python-build-dependency' ],
      [ $PYTHON_DEPEND => qr'\ssetup\.py\b', 'missing-python-build-dependency' ],
-     [ 'quilt (>= 0.46-7~)' => qr'\t\s*dh_quilt_.+' ],
+     [ 'quilt (>= 0.46-7~)' => qr'^\t\s*dh_quilt_.+' ],
      [ quilt => qr'^\t\s*(\S+=\S+\s+)*quilt\s' ],
      [ yada => qr'^\t\s*yada\s' ],
     );

Reply to: