[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://mathematica-fonts/{templates,control}



Hi,

Please find, for review, the debconf templates and packages descriptions
for the mathematica-fonts source package.

This review will last from Thursday, August 30, 2012 to Friday,
September 7, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
> --- a/mathematica-fonts.control
> +++ b/mathematica-fonts.control
> @@ -12,13 +12,13 @@ Pre-Depends: debconf (>= 0.5) | debconf-2.0
>  Provides: ttf-mathematica4.1
>  Conflicts: ttf-mathematica4.1 (<< 9)
>  Replaces: ttf-mathematica4.1 (<< 9)
> -Description: Installer of Mathematica fonts
> - This package downloads Mathematica fonts through an internet
> +Description: installer of Mathematica fonts

Description should not start with an uppercase.

http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis

> + This package downloads Mathematica fonts through Internet

s/an internet/Internet/

>   and installs them, because the license prohibits distribution of
> - the fonts.  NOTE the fonts might be removed from a web site so it
> - might happen that you failed to download the fonts.
> + the fonts. Please note that the fonts might be removed from a web
> + site, so failure to download the fonts may happen.

Reword the note, hopefully I didn't do too bad here, but more
knowledgeable people form the list may improve it further anyway.

> - This package will install only AFM, TTF and Type1 at present.
> + This package will currently only install AFM, TTF and Type1.

Likewise

>  Package: ttf-mathematica4.1
>  Architecture: all
> diff --git a/mathematica-fonts.templates b/mathematica-fonts.templates
> index 40123f5..498627f 100644
> --- a/mathematica-fonts.templates
> +++ b/mathematica-fonts.templates
> @@ -3,9 +3,9 @@ Type: string
>  _Description: HTTP proxy to use:
>   If you need to use a proxy server, please enter it here (example:
>   http://192.168.0.1:8080). This will cause the font file to be
> - downloaded using your proxy.
> + downloaded through the proxy.

I may not own that proxy, so better keep that statement general.

> - Leave this option blank if you don't use a proxy server.
> + Leave this field blank if you don't use a proxy server.

“field” may fit better than “option” for the debconf screen.

> @@ -14,7 +14,7 @@ Type: note
>  # This debconf note displays the original license of fonts
>  # The license terms themselves are not translatable, which explains
>  # that translators do not see them in the PO files
> -Description: License for Mathematica fonts
> +_Description: License for Mathematica fonts

Make template translatable by prepending "_" (the actual reason while
I've spotted this package). Please not that it won't make the license
itself translatable, only the “License for Mathematica fonts” title and
“Read this agreement carefully before […]” paragraph.


Other members of the list may have other remarks and improvements to
propose, thus this formal call for review.

Thanks in advance.

Regards

David

diff --git a/mathematica-fonts.control b/mathematica-fonts.control
index f39320d..bf16c55 100644
--- a/mathematica-fonts.control
+++ b/mathematica-fonts.control
@@ -12,13 +12,13 @@ Pre-Depends: debconf (>= 0.5) | debconf-2.0
 Provides: ttf-mathematica4.1
 Conflicts: ttf-mathematica4.1 (<< 9)
 Replaces: ttf-mathematica4.1 (<< 9)
-Description: Installer of Mathematica fonts
- This package downloads Mathematica fonts through an internet
+Description: installer of Mathematica fonts
+ This package downloads Mathematica fonts through Internet
  and installs them, because the license prohibits distribution of
- the fonts.  NOTE the fonts might be removed from a web site so it
- might happen that you failed to download the fonts.
+ the fonts. Please note that the fonts might be removed from a web
+ site, so failure to download the fonts may happen.
  .
- This package will install only AFM, TTF and Type1 at present.
+ This package will currently only install AFM, TTF and Type1.
 
 Package: ttf-mathematica4.1
 Architecture: all
diff --git a/mathematica-fonts.templates b/mathematica-fonts.templates
index 40123f5..498627f 100644
--- a/mathematica-fonts.templates
+++ b/mathematica-fonts.templates
@@ -3,9 +3,9 @@ Type: string
 _Description: HTTP proxy to use:
  If you need to use a proxy server, please enter it here (example:
  http://192.168.0.1:8080). This will cause the font file to be
- downloaded using your proxy.
+ downloaded through the proxy.
  .
- Leave this option blank if you don't use a proxy server.
+ Leave this field blank if you don't use a proxy server.
 
 Template: mathematica-fonts/license
 Type: note
@@ -14,7 +14,7 @@ Type: note
 # This debconf note displays the original license of fonts
 # The license terms themselves are not translatable, which explains
 # that translators do not see them in the PO files
-Description: License for Mathematica fonts
+_Description: License for Mathematica fonts
  Read this agreement carefully before proceeding. It is an agreement
  between Wolfram Research, Inc. ("WRI") and you. Acceptance of its terms
  creates a binding contract between you and WRI. By downloading the fonts
Template: mathematica-fonts/http_proxy
Type: string
_Description: HTTP proxy to use:
 If you need to use a proxy server, please enter it here (example:
 http://192.168.0.1:8080). This will cause the font file to be
 downloaded through the proxy.
 .
 Leave this field blank if you don't use a proxy server.

Template: mathematica-fonts/license
Type: note
#flag:translate!:3-5
#flag:comment:1
# This debconf note displays the original license of fonts
# The license terms themselves are not translatable, which explains
# that translators do not see them in the PO files
_Description: License for Mathematica fonts
 Read this agreement carefully before proceeding. It is an agreement
 between Wolfram Research, Inc. ("WRI") and you. Acceptance of its terms
 creates a binding contract between you and WRI. By downloading the fonts
 below, you are accepting the terms of this agreement.
 .
 WRI licenses Mathematica fonts to individual users downloading from
 this site. All WRI fonts are copyright Wolfram Research, Inc. or its
 vendors. All rights reserved. WRI fonts are not in the public domain.
 .
 WRI reserves the right to control all distribution of the Mathematica fonts
 and does not, at this time, allow them to be widely distributed via any
 servers, archives, or non-WRI software products of any kind without
 express written consent of WRI. There are no restrictions on embedding
 the fonts in documents transmitted to service bureaus, publishers, or other
 users of WRI products. There are no restrictions on widely distributing
 metrics files generated from the Mathematica fonts.
 .
 WRI does not require authors to credit Wolfram Research for the use of
 the Mathematica fonts in published papers. However, such credit is
 appreciated. "Mathematica fonts by Wolfram Research, Inc." is sufficient.

Template: mathematica-fonts/accept_license
Type: boolean
Default: false
_Description: Do you accept the license of Mathematica fonts?
 In order to install this package, you must accept its license terms.
 Not accepting will cancel the installation.
Source: mathematica-fonts
Section: contrib/fonts
Priority: extra
Maintainer: Atsuhito KOHDA <kohda@debian.org>
Build-Depends: debhelper (>= 7), po-debconf
Standards-Version: 3.8.0

Package: mathematica-fonts
Architecture: all
Depends: ${misc:Depends}, unzip
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Provides: ttf-mathematica4.1
Conflicts: ttf-mathematica4.1 (<< 9)
Replaces: ttf-mathematica4.1 (<< 9)
Description: installer of Mathematica fonts
 This package downloads Mathematica fonts through Internet
 and installs them, because the license prohibits distribution of
 the fonts. Please note that the fonts might be removed from a web
 site, so failure to download the fonts may happen.
 .
 This package will currently only install AFM, TTF and Type1.

Package: ttf-mathematica4.1
Architecture: all
Depends: ${misc:Depends}, mathematica-fonts
Description: transitional dummy package
 This dummy package is provided for a smooth transition from the
 previous ttf-mathematica4.1 package to the mathematica-fonts package.
 .
 It may be safely removed after installation.

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: