[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://kexec-tools/{kexec-tools.templates}



Please find, for review, the debconf templates for the kexec-tools source package.

Packages descriptions were not reviewed as we already did that in the past.

This review will last from Thursday, August 11, 2011 to Sunday, August 21, 2011.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- kexec-tools.old/debian/kexec-tools.templates	2011-08-06 09:18:34.346714760 +0200
+++ kexec-tools/debian/kexec-tools.templates	2011-08-11 09:51:45.354361439 +0200
@@ -4,12 +4,12 @@
 _Description: Should kexec-tools handle reboots?
  If you choose this option, a system reboot will trigger a restart
  into a kernel loaded by kexec instead of going through the full
- system bootloader process.
+ system boot loader process.

"boot loader" in two words. This is what has been normalized in Debian Installer
 
 Template: kexec-tools/use_grub_config
 Type: boolean
 Default: false
-_Description: Should kexec-tools e grub2 config file to load kernel?
- If you choose this option, kexec will read grub2 config file to 
+_Description: Read GRUB configuration file to load the kernel?
+ If you choose this option, kexec will read the GRUB configuration file to
  determine which kernel and options to load for kexec reboot, as opposed
  to what is in /etc/default/kexec.

Fix the typo in synopsis. As the question is rather long, shorten it
down, but use "configuration" as abbreviations should be avoided.

Use standardized capitalization.

There's only GRUB 2 now, so no need to mention the version.

Drop an extra space at the end of one line (the first one in the long description.

-- 


Template: kexec-tools/load_kexec
Type: boolean
Default: true
_Description: Should kexec-tools handle reboots?
 If you choose this option, a system reboot will trigger a restart
 into a kernel loaded by kexec instead of going through the full
 system boot loader process.

Template: kexec-tools/use_grub_config
Type: boolean
Default: false
_Description: Read GRUB configuration file to load the kernel?
 If you choose this option, kexec will read the GRUB configuration file to
 determine which kernel and options to load for kexec reboot, as opposed
 to what is in /etc/default/kexec.
--- kexec-tools.old/debian/kexec-tools.templates	2011-08-06 09:18:34.346714760 +0200
+++ kexec-tools/debian/kexec-tools.templates	2011-08-11 09:51:45.354361439 +0200
@@ -4,12 +4,12 @@
 _Description: Should kexec-tools handle reboots?
  If you choose this option, a system reboot will trigger a restart
  into a kernel loaded by kexec instead of going through the full
- system bootloader process.
+ system boot loader process.
 
 Template: kexec-tools/use_grub_config
 Type: boolean
 Default: false
-_Description: Should kexec-tools e grub2 config file to load kernel?
- If you choose this option, kexec will read grub2 config file to 
+_Description: Read GRUB configuration file to load the kernel?
+ If you choose this option, kexec will read the GRUB configuration file to
  determine which kernel and options to load for kexec reboot, as opposed
  to what is in /etc/default/kexec.
Source: kexec-tools
Section: admin
Homepage: http://kernel.org/pub/linux/utils/kernel/kexec/
Priority: optional
Maintainer: Khalid Aziz <khalid@debian.org>
Build-Depends: debhelper (>= 7.0.0), dpatch, autoconf, gnu-efi (>=3.0a-4)[ia64], libz-dev[ia64], po-debconf
Standards-Version: 3.9.2

Package: kexec-tools
Architecture: i386 amd64 ppc64 powerpc ia64 s390 arm armel
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf
Description: kexec tool for kexec reboots
 This tool is used to load a kernel in memory and reboot into the kernel
 loaded in memory using the kexec system call.

Package: kexec-tools-udeb
Section: debian-installer
Architecture: any
XC-Package-Type: udeb
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: kexec tool for kexec reboots (udeb)

Attachment: signature.asc
Description: Digital signature


Reply to: