<non standard part>Hi Joey!</non standard part> Please find, for review, the debconf templates and packages descriptions for the etckeeper source package. This review will last from Saturday, November 24, 2007 to Tuesday, December 04, 2007. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- ../etckeeper.old/debian/templates 2007-11-16 07:11:06.538381572 +0000 +++ debian/templates 2007-11-20 19:41:44.327672682 +0000 @@ -1,16 +1,19 @@ Template: etckeeper/unclean Type: boolean Default: true +#flag:translate!:3 Avoid offering ${STATUS} for translation$ _Description: Commit changed files in /etc to git? - etckeeper has detected that /etc contains uncommitted files - or other changes. It's best to have everything in /etc committed - to git before running apt. etckeeper can add any new files listed below, - and commit all the changed files for you. + The /etc directory contains uncommitted files + or other changes. All files in /etc should be committed + to git before running APT. The following files may be added + automatically now: Avoid leading lowercase letter and also use a more neutral wording (no need to say that the detection was done by etckeeper). Turn "spoken-style" language (it's best to...) to a more written-style one. . ${STATUS} Template: etckeeper/commit_failed Type: error -_Description: git commit failed - etckeeper failed to commit changes in /etc using git. - You may want to resolve the uncommitted changes by hand before continuing. +_Description: Commit failed Avoid a lowercase-only sentence. Could also be "Commit to goit repository failed" or so.... + An attempt to commit /etc changes to git failed. + . + You should manually solve issues with the uncommitted changes + before continuing. Split in paragraph to separate the explanation of failure from the suggested action. --- ../etckeeper.old/debian/control 2007-11-16 07:11:06.538381572 +0000 +++ debian/control 2007-11-20 19:43:04.823213092 +0000 @@ -11,11 +11,10 @@ Architecture: all Section: admin Depends: metastore, git-core, ${misc:Depends}, debconf | debconf-2.0 -Description: store /etc in git - etckeeper is a collection of tools to let /etc be stored in a git - repository. It hooks into apt to automatically commit changes made to /etc - during package upgrades. It uses `metastore` to track file metadata that +Description: tool to keep /etc changes in git Avoids a sentence in the synopsis + The etckeeper program is a collection of tools to let /etc be stored in a git + repository. It hooks into APT to automatically commit changes made to /etc + during package upgrades. It uses 'metastore' to track file metadata that "The <foo> program" is our usual trick to avoid leading lowercase letters. git does not normally support, but that is important for /etc, such as the - permissions of `/etc/shadow`. It's quite modular and configurable, while + permissions of '/etc/shadow'. It's quite modular and configurable, while We standardisez quoting with single quotes. While the use of backquotes does not seem to be technically wrong in English, analysis showed that keeping things simpler is more widely accepted..:-) also being simple to use if you understand the basics of working with git. - --
Template: etckeeper/unclean Type: boolean Default: true #flag:translate!:3 _Description: Commit changed files in /etc to git? The /etc directory contains uncommitted files or other changes. All files in /etc should be committed to git before running APT. The following files may be added automatically now: . ${STATUS} Template: etckeeper/commit_failed Type: error _Description: Commit failed An attempt to commit /etc changes to git failed. . You should manually solve issues with the uncommitted changes before continuing.
--- ../etckeeper.old/debian/templates 2007-11-16 07:11:06.538381572 +0000 +++ debian/templates 2007-11-20 19:41:44.327672682 +0000 @@ -1,16 +1,19 @@ Template: etckeeper/unclean Type: boolean Default: true +#flag:translate!:3 _Description: Commit changed files in /etc to git? - etckeeper has detected that /etc contains uncommitted files - or other changes. It's best to have everything in /etc committed - to git before running apt. etckeeper can add any new files listed below, - and commit all the changed files for you. + The /etc directory contains uncommitted files + or other changes. All files in /etc should be committed + to git before running APT. The following files may be added + automatically now: . ${STATUS} Template: etckeeper/commit_failed Type: error -_Description: git commit failed - etckeeper failed to commit changes in /etc using git. - You may want to resolve the uncommitted changes by hand before continuing. +_Description: Commit failed + An attempt to commit /etc changes to git failed. + . + You should manually solve issues with the uncommitted changes + before continuing. --- ../etckeeper.old/debian/control 2007-11-16 07:11:06.538381572 +0000 +++ debian/control 2007-11-20 19:43:04.823213092 +0000 @@ -11,11 +11,10 @@ Architecture: all Section: admin Depends: metastore, git-core, ${misc:Depends}, debconf | debconf-2.0 -Description: store /etc in git - etckeeper is a collection of tools to let /etc be stored in a git - repository. It hooks into apt to automatically commit changes made to /etc - during package upgrades. It uses `metastore` to track file metadata that +Description: tool to keep /etc changes in git + The etckeeper program is a collection of tools to let /etc be stored in a git + repository. It hooks into APT to automatically commit changes made to /etc + during package upgrades. It uses 'metastore' to track file metadata that git does not normally support, but that is important for /etc, such as the - permissions of `/etc/shadow`. It's quite modular and configurable, while + permissions of '/etc/shadow'. It's quite modular and configurable, while also being simple to use if you understand the basics of working with git. -
Source: etckeeper Section: admin Priority: optional Build-Depends: debhelper (>= 5), dpkg-dev (>= 1.9.0) Maintainer: Joey Hess <joeyh@debian.org> Standards-Version: 3.7.2 Vcs-Git: git://git.kitenet.net/etckeeper Homepage: http://kitenet.net/~joey/code/etckeeper/ Package: etckeeper Architecture: all Section: admin Depends: metastore, git-core, ${misc:Depends}, debconf | debconf-2.0 Description: tool to keep /etc changes in git The etckeeper program is a collection of tools to let /etc be stored in a git repository. It hooks into APT to automatically commit changes made to /etc during package upgrades. It uses 'metastore' to track file metadata that git does not normally support, but that is important for /etc, such as the permissions of '/etc/shadow'. It's quite modular and configurable, while also being simple to use if you understand the basics of working with git.
Attachment:
signature.asc
Description: Digital signature