Please find, for review, the debconf templates and packages descriptions for the fdutils source package. This review will last from Wednesday, December 19, 2007 to Saturday, December 29, 2007. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. Rationale: --- ../fdutils.old/debian/templates 2007-12-17 01:58:55.040209902 +0530 +++ debian/templates 2007-12-19 12:04:53.332381106 +0530 @@ -1,7 +1,9 @@ Template: fdutils/fdmount_setuid Type: boolean Default: false -_Description: Do you want to make fdmount set-user-id root? +_Description: Should fdmount be installed 'setuid root'? In order to enable ordinary users to mount a floppy disk using fdmount, - fdmount needs to be set up as set-user-id root. Please note that this is - usually considered to be a security hazard. + the fdmount program can be installed with the set-user-id bit set, so + that it will run with the permissions of the superuser. We alredy use such formulation for man-db + . + Such setting may have security implications in case of + vulnerabilities in the software's code. split in a separate paragraph. Use more neutral wording. --- ../fdutils.old/debian/control 2007-12-17 01:58:55.040209902 +0530 +++ debian/control 2007-12-19 12:06:19.327992009 +0530 @@ -4,6 +4,7 @@ Maintainer: Anibal Monsalve Salazar <anibal@debian.org> Standards-Version: 3.7.2 Build-Depends: debhelper (>= 5), texi2html, flex, tetex-bin, texinfo, po-debconf +Homepage: http://www.tux.org/pub/knaff/fdutils/ Use the new dpkg field Package: fdutils Architecture: any @@ -12,25 +13,23 @@ Replaces: miscutils, manpages (<< 1.11-3) Description: Linux floppy utilities This package contains utilities for formatting extra capacity - disks, for automatic floppy disk mounting and unmounting, etc. + disks, automatic floppy disk mounting and unmounting, etc. Was the "for" needeed? . The package includes the following items: . - * superformat: formats high capacity disks of (up to 1992k - for high density disks or up to 3984k for extra density - disks) - * fdmount: automatically mounts/unmounts disks when they are - inserted/removed. - * xdfcopy: formats, reads and writes OS/2's XDF disks. - * MAKEFLOPPIES: creates the floppy devices in /dev - * getfdprm: prints the current disk geometry (number of - sectors, track and heads etc) - * setfdprm: sets the current disk geometry - * fdrawcmd: sends raw commands to the floppy driver - * floppycontrol: configure the floppy driver - * General documentation about the floppy driver + - superformat: formats high capacity disks of (up to 1992k + for high density disks or up to 3984k for extra density + disks); + - fdmount: automatically mounts/unmounts disks when they are + inserted/removed; + - xdfcopy: formats, reads and writes OS/2's XDF disks; + - MAKEFLOPPIES: creates the floppy devices in /dev; + - getfdprm: prints the current disk geometry (number of + sectors, track and heads etc); + - setfdprm: sets the current disk geometry; + - fdrawcmd: sends raw commands to the floppy driver; + - floppycontrol: configure the floppy driver; + - General documentation about the floppy driver. Standardize enumeration. . Note that these utilities do not work for USB floppy drives, because there is no direct access to the floppy controller. - . - Homepage: http://www.tux.org/pub/knaff/fdutils/ Moved to its own field. --
Template: fdutils/fdmount_setuid Type: boolean Default: false _Description: Should fdmount be installed 'setuid root'? In order to enable ordinary users to mount a floppy disk, the fdmount program can be installed with the set-user-id bit set, so that it will run with the permissions of the superuser. . Such setting may have security implications in case of vulnerabilities in the software's code.
--- fdutils.old/debian/templates 2007-12-17 01:58:55.040209902 +0530 +++ fdutils/debian/templates 2007-12-19 22:32:43.458727846 +0530 @@ -1,7 +1,10 @@ Template: fdutils/fdmount_setuid Type: boolean Default: false -_Description: Do you want to make fdmount set-user-id root? - In order to enable ordinary users to mount a floppy disk using fdmount, - fdmount needs to be set up as set-user-id root. Please note that this is - usually considered to be a security hazard. +_Description: Should fdmount be installed 'setuid root'? + In order to enable ordinary users to mount a floppy disk, + the fdmount program can be installed with the set-user-id bit set, so + that it will run with the permissions of the superuser. + . + Such setting may have security implications in case of + vulnerabilities in the software's code. --- fdutils.old/debian/control 2007-12-17 01:58:55.040209902 +0530 +++ fdutils/debian/control 2007-12-19 22:35:07.451549537 +0530 @@ -4,6 +4,7 @@ Maintainer: Anibal Monsalve Salazar <anibal@debian.org> Standards-Version: 3.7.2 Build-Depends: debhelper (>= 5), texi2html, flex, tetex-bin, texinfo, po-debconf +Homepage: http://www.tux.org/pub/knaff/fdutils/ Package: fdutils Architecture: any @@ -12,25 +13,23 @@ Replaces: miscutils, manpages (<< 1.11-3) Description: Linux floppy utilities This package contains utilities for formatting extra capacity - disks, for automatic floppy disk mounting and unmounting, etc. + disks, automatic floppy disk mounting and unmounting, etc. . The package includes the following items: . - * superformat: formats high capacity disks of (up to 1992k - for high density disks or up to 3984k for extra density - disks) - * fdmount: automatically mounts/unmounts disks when they are - inserted/removed. - * xdfcopy: formats, reads and writes OS/2's XDF disks. - * MAKEFLOPPIES: creates the floppy devices in /dev - * getfdprm: prints the current disk geometry (number of - sectors, track and heads etc) - * setfdprm: sets the current disk geometry - * fdrawcmd: sends raw commands to the floppy driver - * floppycontrol: configure the floppy driver - * General documentation about the floppy driver + - superformat: formats high capacity disks of (up to 1992k + for high density disks or up to 3984k for extra density + disks); + - fdmount: automatically mounts/unmounts disks when they are + inserted/removed; + - xdfcopy: formats, reads and writes OS/2's XDF disks; + - MAKEFLOPPIES: creates the floppy devices in /dev; + - getfdprm: prints the current disk geometry (number of + sectors, track and heads etc); + - setfdprm: sets the current disk geometry; + - fdrawcmd: sends raw commands to the floppy driver; + - floppycontrol: configure the floppy driver; + - general documentation about the floppy driver. . Note that these utilities do not work for USB floppy drives, because there is no direct access to the floppy controller. - . - Homepage: http://www.tux.org/pub/knaff/fdutils/
Source: fdutils
Section: utils
Priority: optional
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Standards-Version: 3.7.2
Build-Depends: debhelper (>= 5), texi2html, flex, tetex-bin, texinfo, po-debconf
Homepage: http://www.tux.org/pub/knaff/fdutils/
Package: fdutils
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debianutils (>= 1.7)
Recommends: mtools (>= 3.8-1)
Replaces: miscutils, manpages (<< 1.11-3)
Description: Linux floppy utilities
This package contains utilities for formatting extra capacity
disks, automatic floppy disk mounting and unmounting, etc.
.
The package includes the following items:
.
- superformat: formats high capacity disks of (up to 1992k
for high density disks or up to 3984k for extra density
disks);
- fdmount: automatically mounts/unmounts disks when they are
inserted/removed;
- xdfcopy: formats, reads and writes OS/2's XDF disks;
- MAKEFLOPPIES: creates the floppy devices in /dev;
- getfdprm: prints the current disk geometry (number of
sectors, track and heads etc);
- setfdprm: sets the current disk geometry;
- fdrawcmd: sends raw commands to the floppy driver;
- floppycontrol: configure the floppy driver;
- general documentation about the floppy driver.
.
Note that these utilities do not work for USB floppy drives, because
there is no direct access to the floppy controller.
Attachment:
signature.asc
Description: Digital signature