Bug#1082647: copy_exec: [regression] ignores trailing slash, installs file as directory name

[Thorsten Glaser <tg@mirbsd.de>]

On Tue, 24 Sep 2024, Ben Hutchings wrote:

>> Two, say people are expected to create the directories first.
>> But in that case, copy_exec also must not create any missing
>> directories any more *at all*,
>
>No, it was documented to do that for the case where no target argument
>was given, and changing that would likely cause widespread breakage.

Right, totally. I was thinking of the two-argument case only.

>> and additionally, if the target
>> ends in a slash in the argv (i.e. before realpathisation), it
>> still must be interpreted as the name of a directory (or symlink
>> to a directory), so that copying to '/usr/libexec/' will either
>> work (if pre-created) or fail (if not pre-created).
>
>I agree that we mustn't create the target filename as a regular file if
>it originally ended with a slash.

Thanks.

>Now that I've tested, I see that this has worked since at least squeeze
>(that's the oldest image I have available).  So I'm now leaning towards
>restoring and documenting it.

OK, thanks.

bye,
//mirabilos
-- 
16:47⎜«mika:#grml» .oO(mira ist einfach gut....)      23:22⎜«mikap:#grml»
mirabilos: und dein bootloader ist geil :)    23:29⎜«mikap:#grml» und ich
finds saugeil dass ich ein bsd zum booten mit grml hab, das muss ich dann
gleich mal auf usb-stick installieren	-- Michael Prokop über MirOS bsd4grml