[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1027430: linux-image-5.10.0-20-amd64: No sound on Lenovo IdeaPad 3



Hi Martin,

On Sun, Jan 01, 2023 at 08:50:34PM +0100, Martin Furlanic wrote:
> I'm quite a knowlegeable user and glad to help, but I think I'll be needing
> some directons on how to do it. At this point I'm booting the machine with
> the linux-image-5.10.0-19, just the one before the december release of
> updates, and everything is working well as before.

Thank you. In #1027483 PÁLFFY Dániel bisected the issue down to commit
c34db0d6b88b ("ASoC: soc-pcm: Don't zero TDM masks in
__soc_pcm_open()").

If you would be able to confirm as well that such a revert fixes the
issue that would be of help indeed.

We have some instruction here on how to build Debian's kernel with a
single patch on top:
https://kernel-team.pages.debian.net/kernel-handbook/ch-common-tasks.html#s4.2.2

The patch which would need to be applied is the revert of the above
commit, which I'm attaching here.

Regards,
Salvatore
>From 039fd15cf22a0807f8e68fc8ba9fa0d3c015bf18 Mon Sep 17 00:00:00 2001
From: Salvatore Bonaccorso <carnil@debian.org>
Date: Mon, 2 Jan 2023 11:32:44 +0100
Subject: [PATCH] Revert "ASoC: soc-pcm: Don't zero TDM masks in
 __soc_pcm_open()"

This reverts commit c34db0d6b88b1da95e7ab3353e674f4f574cccee.
---
 sound/soc/soc-pcm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index fb874f924bbe..9a60d62f12fe 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -723,6 +723,11 @@ static int soc_pcm_open(struct snd_pcm_substream *substream)
 		ret = snd_soc_dai_startup(dai, substream);
 		if (ret < 0)
 			goto err;
+
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+			dai->tx_mask = 0;
+		else
+			dai->rx_mask = 0;
 	}
 
 	/* Dynamic PCM DAI links compat checks use dynamic capabilities */
-- 
2.39.0


Reply to: