Re: [Pkg-alsa-devel] Processed: reassign 617743 alsa-driver

[Tarek Soliman <tarek@bashasoliman.com>]

On Sun, Apr 03, 2011 at 04:25:16AM +0100, Ben Hutchings wrote:
> On Fri, 2011-04-01 at 01:03 -0500, Tarek Soliman wrote:
> > On Thu, Mar 31, 2011 at 08:01:37PM +0100, Ben Hutchings wrote:
> > > On Thu, Mar 31, 2011 at 08:30:23PM +0200, Elimar Riesebieter wrote:
> > > > * Debian Bug Tracking System [110331 03:39 +0000]:
> > > > > Processing commands for control@bugs.debian.org:
> > > > > 
> > > > > > reassign 617743 alsa-driver
> > > > > Bug #617743 [linux-2.6] linux-image-2.6.37-2-686: found another USB midi cable with a 4 byte limit
> > > > > Bug reassigned from package 'linux-2.6' to 'alsa-driver'.
> > > > > Bug No longer marked as found in versions 2.6.37-2.
> > > > 
> > > > This can be fixed easy to the alsa-source package. The fix will then
> > > > be valid for users who build their alsa-drivers from alsa-source.
> > > > But people using alsa drivers from Debian's kernel won't, though.
> > >  
> > > I agree it should be fixed in linux-2.6.  But it should be accepted
> > > upstream first, and filing a bug in the upstream bug tracker is
> > > probably not the way to get this done!
> > 
> > What is the correct way to get this accepted upstream?
> 
> Add a 'signed-off-by' statement to your patch as explained in section 12
> of <http://www.kernel.org/doc/Documentation/SubmittingPatches>, then
> send it to Clemens Ladisch <clemens@ladisch.de> and the ALSA developer
> list <alsa-devel@alsa-project.org>.

I submitted it and it got accepted into the sound tree.
It is not yet in the Linus tree.
It has been slightly modified.
Here is the commit from the sound tree (attached)

Do we have to wait until Linus Torvalds merges it?
-- 
Tarek

>From 49c039f071d36586ba32da75996ef339e4ab8405 Mon Sep 17 00:00:00 2001
From: Tarek Soliman <tarek@bashasoliman.com>
Date: Mon, 4 Apr 2011 09:23:53 -0500
Subject: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable

There are many USB MIDI cables out there that have buggy
firmware that reports it can do more than 4 bytes in a
packet when they can only properly handle 4

This patch adds the ID of yet another one of those cables

Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/midi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index b4b39c0..f928910 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
 	case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
 	case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
 	case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
+	case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
 		ep->max_transfer = 4;
 		break;
 		/*
-- 
1.7.4.1