[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#577149: configure_networking: pxelinux BOOTIF fixes



Package: initramfs-tools
Version: 0.94.4
Severity: normal
Tags: patch

looks like i missed a few things on implementing BOOTIF support properly.

somehow i managed to get the order of the mac address backwards. i know i
tested it many times, but somehow the patch i submitted got it backwards:

diff --git a/scripts/functions b/scripts/functions
index 7b68255..f854495 100644
--- a/scripts/functions
+++ b/scripts/functions
@@ -323,7 +323,7 @@ configure_networking()
 			if [ -z "$bootif_mac" ]; then
 				bootif_mac="$x"
 			else
-				bootif_mac="$x:$bootif_mac"
+				bootif_mac="$bootif_mac:$x"
 			fi
 		done
 		unset IFS


as mentioned by Christoph Bussenius in #535008, it does appear that setting
BOOTIF from the value in /proc/cmdline is needed. at the time i wrote the
patch, i'm not sure it was, but it definitely is now:

diff --git a/init b/init
index 7d0db07..142eb14 100755
--- a/init
+++ b/init
@@ -175,6 +175,9 @@ for x in $(cat /proc/cmdline); do
 	netconsole=*)
 		netconsole=${x#netconsole=}
 		;;
+	BOOTIF=*)
+		BOOTIF=${x#BOOTIF=}
+		;;
 	esac
 done
 

with these patchese applied, it seems to work. at least for the moment.

live well,
  vagrant



Reply to: