[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#407217: Multicast broken in r8169 for one version of Thecus N2100



On Sun, 2010-03-07 at 20:48 +0600, Mikhail Gusarov wrote:
> Twas brillig at 14:41:10 07.03.2010 UTC+00 when tbm@cyrius.com did
> gyre and gimble:
> 
>  >> Just tested it. Works fine here (mDNS resolves without promisc mode
>  >> on interface), thanks.
> 
>  MM> Good to hear!  That patch also included some debugging output.  Can
>  MM> you please send the output from "dmesg"?
> 
> Attached.
> 
> [looking at dmesg: wow, looks like I just found wireless card I lost
> some time ago - it's mini-PCI slot in NAS :]
[...]
> [  424.350000] device eth0 left promiscuous mode
> [  424.350000] rtl_set_rx_mode: mc_filter = { 0x80088000, 0x40004000 }
> [  424.350000] rtl_set_rx_mode: MAR = 0x4000400040004000
> [  424.350000] rtl_set_rx_mode: MAR = 0x4000400080088000 
[...]

As I suspected, writing the high bits also changes the low bits so we
must write high before low.

The next question is whether doing that works for all r8169 variants or
whether it needs to be conditional.

Ben.

-- 
Ben Hutchings
The most exhausting thing in life is being insincere. - Anne Morrow Lindberg

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: