[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#593304: linux-2.6: Removal and reinsertion of floppy or mtdblock device can cause oops



Package: linux-2.6
Version: 2.6.26-24
Severity: important

There is a bug in the backing-device sysfs code, added in 2.6.26 and
fixed in 2.6.28 by the following commits:

commit f1d0b063d993527754f062c589b73f125024d216
Author: Kay Sievers <kay.sievers@vrfy.org>
Date:   Tue Dec 2 10:31:50 2008 -0800

    bdi: register sysfs bdi device only once per queue
    
    Devices which share the same queue, like floppies and mtd devices, get
    registered multiple times in the bdi interface, but bdi accounts only the
    last registered device of the devices sharing one queue.
    
    On remove, all earlier registered devices leak, stay around in sysfs, and
    cause "duplicate filename" errors if the devices are re-created.

commit 69fc208be5b7eb18d22d1eca185b201400fd5ffc
Author: Andrew Morton <akpm@linux-foundation.org>
Date:   Tue Dec 9 13:14:06 2008 -0800

    mm/backing-dev.c: remove recently-added WARN_ON()
    
    On second thoughts, this is just going to disturb people while telling us
    things which we already knew.

In the case of mtdblock the result of the bug is not just a warning but
an oops (use of null pointer) that leaves the system unusable.  I'm not
sure about the floppy driver.  In any case, these changes are small and
seem low-risk; they were also accepted in stable version 2.6.27.51.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: