On Wed, 2010-08-11 at 08:48 -0700, Jeremy Fitzhardinge wrote: > On 08/11/2010 08:17 AM, Ian Campbell wrote: > > On Wed, 2010-08-11 at 07:55 -0700, Jeremy Fitzhardinge wrote: > >> It's not clear that xsave could ever be usable by PV guests, even in > >> principle, so its probably all completely over-engineered. If setting > >> X86_CR4_OSXSAVE is problematic, then simply adding it to the list of > >> things we mask out of cpuid is probably the best fix. > > Agreed and I think on that basis we should take the proposed patch into > > the Debian kernel. > > > > This should work: [...] Your patch had mangled spacing around operators. This seems to be a bug in recent versions of Thunderbird, possibly related to <https://bugzilla.mozilla.org/show_bug.cgi?id=571502>. I was able to fix it up in this case as the context is obvious, but please avoid Thunderbird for inline patches or find a way to avoid this bug. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part