Bug#587329: fix for some errors introduced with patch 11
On Sun, 27 Jun 2010, Ben Hutchings wrote:
> On Sun, 2010-06-27 at 17:05 +0200, Cristian Ionescu-Idbohrn wrote:
> > Another patch attached.
>
> So far as I can see, these patches break down as:
>
> 02. I don't think we want to do this. I think the script should fail
> noisily if files are present but unreadable.
Seems reasonable. But in that case you may want to abort, instead of
continueing, when prequisites are not fulfilled.
> 03. Fixes this bug.
Check.
> 10. Fixes another minor bug.
Check.
> 11 + 13. Worthwhile cleanup.
Check.
> 12. Worthwhile cleanup.
Check.
> 01, 04-09. Stylistic changes, matter of preference.
Right.
Cherripick as you please, but think efficientcy and maintainence ease ;)
Cheers,
--
Cristian
Reply to: