On Tue, 2010-06-15 at 08:54 +0100, Mark Hymers wrote:
> On Tue, 15, Jun, 2010 at 01:44:45AM +0100, Ben Hutchings spoke thus..
[...]
> > > tty = tty_port_tty_get(&port->port);
> > > if (urb->actual_length) {
> > > - tty_buffer_request_room(tty, urb->actual_length);
> >
> > Should this really have been removed?
Answer: yes, it is pointless to call this function without checking the
result, and tty_insert_flip_string() calls it properly.
> > > @@ -224,9 +224,9 @@
> > > tty_kref_put(tty);
> > >
> > > /* Resubmit urb so we continue receiving */
> > > - if (port->port.count && status != -ESHUTDOWN) {
> > > + if (status != -ESHUTDOWN) {
> > > err = usb_submit_urb(urb, GFP_ATOMIC);
> > > - if (err)
> > > + if (err && err != -EPERM)
> >
> > What's correct here?
>
> For both of these, comparing what was merged upstream and what was in
> the 2.6.32 original patch from Matthew's website, the split out version
> from git is what was merged upstream.
[...]
I understood that, but wanted to check that there was not a semantic
difference between 2.6.32 and .35 that made the former correct.
However, now that I've looked more closely I think this change is valid
for both versions.
Therefore, I'm applying the changes you sent.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part