Re: RFS: jug 2.0.0-1

[Onkar Shinde <onkarshinde@gmail.com>]

On Thu, Nov 26, 2009 at 4:29 PM, Mehdi Dogguy <mehdi@dogguy.org> wrote:
> Onkar Shinde wrote:
>> I am looking for sponsorship of jug 2.0.0-1. This closes ITP 557835.
>> This package is mainly a port of the package from Ubuntu and it is one
>> of the essential (build)dependency of cruisecontrol. I request that
>> the orig.tar.gz I uploaded to mentors.d.n be used so that the package
>> can then be synced to Ubuntu directly.
>>
>> The package is available at -
>> http://mentors.debian.net/debian/pool/main/j/jug/jug_2.0.0-1.dsc
>>
>
> Some remarks after looking at it:
> - I noticed that you have already some packages with DMUA activated.
>  So, it's ok for me unless there is someone on this list against.
> - There is a missing copyright:
>  * java/com/ccg/net/ethernet/EthernetAddress.java
>    (c)2001 - Paul Blankenbaker
>  * java/com/ccg/net/ethernet/BadAddressException.java
>    has a malformed (missing?) copyright statement:
>    (c)2001 -

I will add 'Paul Blankenbaker' to debian/copyright.

> - The C sources don't have any copyright notice

The release-notes/CREDITS and release-notes/README files mention that
'D.J Hagberg' contributed native code for Mac OS X and rest of native
code was contributed by 'Paul Blankenbaker'. Is this sufficient?

>  * There is a mention to user (namely "pkb") which should
>    correspond to Paul Blankenbaker but it's only a guess.
>    The $Id$ line dates back to 2001. So "(c)2001 - Paul Blankenbaker"
>    should really appear in debian/copyright.
>
> The rest is ok for me.


Onkar