[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: jug 2.0.0-1



Onkar Shinde wrote:
> I am looking for sponsorship of jug 2.0.0-1. This closes ITP 557835.
> This package is mainly a port of the package from Ubuntu and it is one
> of the essential (build)dependency of cruisecontrol. I request that
> the orig.tar.gz I uploaded to mentors.d.n be used so that the package
> can then be synced to Ubuntu directly.
> 
> The package is available at -
> http://mentors.debian.net/debian/pool/main/j/jug/jug_2.0.0-1.dsc
> 

Some remarks after looking at it:
- I noticed that you have already some packages with DMUA activated.
  So, it's ok for me unless there is someone on this list against.
- There is a missing copyright:
  * java/com/ccg/net/ethernet/EthernetAddress.java
    (c)2001 - Paul Blankenbaker
  * java/com/ccg/net/ethernet/BadAddressException.java
    has a malformed (missing?) copyright statement:
    (c)2001 -
- The C sources don't have any copyright notice
  * There is a mention to user (namely "pkb") which should
    correspond to Paul Blankenbaker but it's only a guess.
    The $Id$ line dates back to 2001. So "(c)2001 - Paul Blankenbaker"
    should really appear in debian/copyright.

The rest is ok for me.

Cheers,

-- 
Mehdi Dogguy مهدي الدڤي
http://dogguy.org/


Reply to: