[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New version 17.0.272 of keyman package uploaded to mentors.debian.net



Great. Thanks!

Boyuan Yang wrote on 2024-02-21 20:23:
在 2024-02-21星期三的 16:51 +0100,Eberhard Beilharz写道:
  Hi,
  Thanks for taking a look. I uploaded 17.0.272-1 which should address these issues.
Boyuan Yang wrote on 2024-02-20 21:07:
This looks like a major rehaul of keyman packages. As a result, I want to
explicitly postpone it so that it could *miss* the Ubuntu 24.04 LTS import
deadline (i.e. 2024-02-29).
  That's disappointing. I had hoped to get the new version into 24.04.

Even if I want to expedite the upload, your new version will need manual
approval in Debian NEW queue due to introducing new binary packages.

Now I am uploading your new version to Debian as-is, and it will be out of
my control whether the new upload can be cleared before Ubuntu 24.04 LTS
import deadline.


I believe the following issues may need more explanation or revision:

*) Your library package libkeymancore is missing SONAME in library name,
which could make its further handling problematic. Please restore the
name to be libkeymancore0.
  Ah, right. I overlooked that part of the policy (section 8.1). Done.
*) You do not need to place "quilt" in Build-Depends field.

  Done.
*) Please use merged-usr layout in your override_dh_auto_configure. Currently
you are using lib/$(DEB_TARGET_MULTIARCH). You should be using
usr/lib/$(DEB_TARGET_MULTIARCH).
The files do end up in /usr/lib/$(DEB_TARGET_MULTIARCH) because of the relative path, so I don't think I should change that. Otherwise I think the files will land in
/usr/usr/lib/$(DEB_TARGET_MULTIARCH) which isn't what we want.
Thanks, it looks like some quirk in the custom build system. As long as files
are installed to the correct location, it should be fine.

Thanks,
Boyuan Yang

Attachment: OpenPGP_0xE9140597606020D3.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: