[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gcc-13: hurd-amd64 support



Hi!

On Sat, 2023-05-06 at 15:27:34 +0200, Samuel Thibault wrote:
> Package: gcc-13
> Version: 13.1.0-1
> Severity: important
> Tags: patch

> We're starting the hurd-amd64 port :)
> 
> Here is a patch to add support to the gcc package (here against the
> master branch).

Ah, just today I wondered whether I should be letting dpkg handle
hurd-amd64 as having builtin PIE support, when I now noticed this
patch!

> diff --git a/debian/rules.defs b/debian/rules.defs
> index 26e41e7..864d133 100644
> --- a/debian/rules.defs
> +++ b/debian/rules.defs
[…]
> @@ -1469,7 +1469,7 @@ ifeq ($(distribution),Debian)
>  		mips mipsel mips64 mips64el mipsn32 mipsn32el \
>  		mipsr6 mipsr6el mips64r6 mips64r6el mipsn32r6 mipsn32r6el \
>  		ppc64el s390x sparc sparc64 kfreebsd-amd64 kfreebsd-i386 \
> -		hurd-i386 riscv64
> +		hurd-amd64 hurd-i386 riscv64
>    endif
>    ifeq (,$(filter $(distrelease), jessie stretch))
>      pie_archs += powerpc ppc64

(Had to download the gcc-13 sources, as the context was not obvious
from here, but I see it's now even applied there.)

I've queued the attached patch for my next push to dpkg.

Thanks,
Guillem
From 42fbe972975ec707951e699147f42dd0cb51a3f8 Mon Sep 17 00:00:00 2001
From: Guillem Jover <guillem@debian.org>
Date: Thu, 11 May 2023 02:18:38 +0200
Subject: [PATCH] Dpkg::Vendor::Debian: Mark PIE as builtin on hurd-amd64

This new port that is currently being bootstrapped will default to
handle PIE enabled builtin in gcc, so we need to let the build flags
work accordingly.
---
 scripts/Dpkg/Vendor/Debian.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/Dpkg/Vendor/Debian.pm b/scripts/Dpkg/Vendor/Debian.pm
index 6e5d308ae..d80564356 100644
--- a/scripts/Dpkg/Vendor/Debian.pm
+++ b/scripts/Dpkg/Vendor/Debian.pm
@@ -241,6 +241,7 @@ sub set_build_features {
         arm64
         armel
         armhf
+        hurd-amd64
         hurd-i386
         i386
         kfreebsd-amd64
-- 
2.40.1


Reply to: