[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#884894: newsboat: FTBFS on hurd-i386: MAXPATHLEN not declared



Source: newsboat
Version: 2.10.1-1
Severity: important
Tags: upstream
Justification: fails to build from source
User: debian-hurd@lists.debian.org
Usertags: hurd-i386

Builds of newsboat for hurd-i386 (admittedly not a release architecture)
have been failing with a cascade of errors starting with

  src/utils.cpp: In static member function 'static std::__cxx11::string newsbeuter::utils::getcwd()':
  src/utils.cpp:1110:14: error: 'MAXPATHLEN' was not declared in this scope
    char cwdtmp[MAXPATHLEN];

The Hurd famously has no static MAXPATHLEN (or PATH_MAX).  Best practice
is to work dynamically with what you encounter (for instance, with the
help of the glibc extension get_current_dir_name).  However, if that's
infeasible, you can also look up _PC_PATH_MAX via pathconf or supply a
fallback constant (traditionally 4096).

Could you please take a look?

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu


Reply to: