Re: appstream-glib: FTBFS on hurd-i396 (for review)
Svante Signell, le Wed 22 Oct 2014 11:33:39 +0200, a écrit :
> On Wed, 2014-10-22 at 11:11 +0200, Pino Toscano wrote:
> > On 2014-10-22 10:59, Svante Signell wrote:
> > >
> > > Updated patch attached. For the first part of the patch, I don't find
> > > using g_strdup_printf() is an advantage over g_malloc(), since later
> > > on
> > > g_realloc() is needed.
> > The other option is to just use a different buffer for each path, which
> > could actually simplify the code (you are also not checking whether a
> > new length is smaller than the previous one, to avoid realloc).
> Yes, that could be a solution too, Samuel?
What looks nicer is usually what maintainers prefer.