Re: xdebug: FTBFS on hurd-i386 (for review)
Svante Signell, le Tue 15 Apr 2014 14:18:44 +0200, a écrit :
> On Tue, 2014-04-15 at 13:29 +0200, Samuel Thibault wrote:
> > Svante Signell, le Tue 15 Apr 2014 12:07:22 +0200, a écrit :
> > > > Will obviously crash. Did you try your code at all?
> > >
> > > I wrote a test program and run that one through valgind. Better now?
> > Did you really make your program go through your patched code?
> > > + dfp = xdstrdup(efp);
> > That doesn't get free in the if branch.
> How to do that properly then?
Just like the original source code for instance: keep the allocated
pointer in dfp, and use fp for browsing it.