[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Unofficial GNU/Hurd release (#636568)



Hi,

Alle giovedì 11 ottobre 2012, Svante Signell ha scritto:
> > > -    if (!curDir)
> > > +    if (curDir == NULL)
> > 
> > Why did you change this?
> 
> Dunno, changed!

Usually reading a patch before sending it would help, also with...

> -    return XMLString::transcode(curDir, manager);
> +        XMLCh *ret = XMLString::transcode(curDir, manager);

.. this, which has an indentation change.

> A new patch attached. OK now?

With the above fixed, yes.

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: