[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[debian-hurd-Patches][304463] ecl autotools



Patches item #304463, was opened at 10/02/2007 16:46
Status: Open
Priority: 3
Submitted By: Pierre THIERRY (nowhrman-guest)
Assigned to: Nobody (None)
Summary: ecl autotools 
Resolution: None
Group: unreviewed
Category: other


Initial Comment:
ECL was impossible to build because it's autotools data lacked info about the GNU system. It can be built with the following patch (and updating with autoconf):

diff -r 045b9347e44a src/h/config.h.in
--- a/src/h/config.h.in Tue Feb 06 17:36:54 2007 +0100
+++ b/src/h/config.h.in Sat Feb 10 04:15:48 2007 +0100
@@ -302,7 +302,7 @@ typedef unsigned @CL_FIXNUM_TYPE@ cl_has
 #include "@ECL_FPE_CODE@"

 #if defined(ECL_THREADS)
-# if defined(darwin) || defined(freebsd)
+# if defined(darwin) || defined(freebsd) || defined(gnu)
 #  define PTHREAD_MUTEX_ERRORCHECK_NP PTHREAD_MUTEX_ERRORCHECK
 #  define PTHREAD_MUTEX_RECURSIVE_NP PTHREAD_MUTEX_RECURSIVE
 #  define PTHREAD_MUTEX_NORMAL_NP PTHREAD_MUTEX_NORMAL



diff -r 045b9347e44a src/aclocal.m4
--- a/src/aclocal.m4    Tue Feb 06 17:36:54 2007 +0100
+++ b/src/aclocal.m4    Sat Feb 10 03:55:51 2007 +0100
@@ -188,6 +188,16 @@ case "${host_os}" in
        # libdir may have a dollar expression inside
        linux*)
                thehost='linux'
+               THREAD_CFLAGS='-D_THREAD_SAFE'
+               THREAD_LIBS='-lpthread'
+               SHARED_LDFLAGS="-shared ${LDFLAGS}"
+               BUNDLE_LDFLAGS="-shared ${LDFLAGS}"
+               LDRPATH='-Wl,--rpath,/usr/lib/ecl/'
+               clibs="-ldl"
+               # Maybe CFLAGS="-D_ISOC99_SOURCE ${CFLAGS}" ???
+               ;;
+       gnu*)
+               thehost='gnu'
                THREAD_CFLAGS='-D_THREAD_SAFE'
                THREAD_LIBS='-lpthread'
                SHARED_LDFLAGS="-shared ${LDFLAGS}"



----------------------------------------------------------------------

Comment By: Pierre THIERRY (nowhrman-guest)
Date: 10/02/2007 17:38

Message:
I'm not comfortable at all with autotools, so this patch was just the path of least resistance, and also respect the principle of least surprise (it adds something, doesn't change anything existing).

----------------------------------------------------------------------

Comment By: Samuel Thibault (sthibaul-guest)
Date: 10/02/2007 17:13

Message:
Why not sharing the aclocal.m4 part ? compilation & linking stuff should always be the same on both systems, since both are GNU-based.


----------------------------------------------------------------------

You can respond by visiting: 
http://alioth.debian.org/tracker/?func=detail&atid=410472&aid=304463&group_id=30628



Reply to: