Re: Condor Upload
Hi,
Am Tue, Nov 01, 2022 at 09:34:26PM -0500 schrieb Tim Theisen:
> Answers inline.
As always on Debian lists. ;-)
> On 11/1/22 07:50, Andreas Tille wrote:
> > Seems my suggestion is void since we have to rename former libclassad8
> > to libclassad15 anyway. Please confirm you understood that we need to
> > adapt d/copyright to the actual status *urgently* if we want to have
> > the slightest chance that condor will pass ftpmaster inspection. This
> > is probably even more important than those lintian issues.
>
> I see that the upstream copyright file is not up to date. I will have a
> complete version within 24 hrs.
If you need to do changes *upstream* than you should do a new micro
release we should package. I personally was talking about
debian/copyright which needs to mention *extremely picky* every single
contributor, specifically of third party code.
> I have used the Debian copyright tools before and know how to use them
Good. :-)
> > > Definitely. Unfortunately I have not dealt with systemd yet. Thus I
> > > left this untouched. May be its a good idea if you would concentrate on
> > > this (seeking for examples at https://codesearch.debian.net or ask for
> > > some help on debian-mentors@lists.debian.org is highly recommended).
> I have a good idea on how to address the systemd files. What we have now
> works. So, this lower priority.
Perfectly fine for me.
> > needs to be mentioned in d/copyright. If these files could be simply
> > removed from the upstream tarball since they might not be used in the
> > build process this would save a lot of work. You can get a first
> > impression what needs checking by
> >
> > grep -Ri copyright | grep -v ^debian
That's not really a "Debian copyright tool" ... but it works nicely.
> > Back to some lintian issues:
> >
> > E: htcondor: no-debconf-config
> >
> > I have no idea whether debconf questions are needed for htcondor
> > installation but if not simply removing the file
> > debian/htcondor.templates
> > would make this error vanish.
> This is an error on my part. htcondor.template should be removed.
Removed in Git.
> > I've also removed the file
> > /etc/rc.d/init.d/glite-ce-blah-parser
> > from htcondor package since you are not permitted to install files to
> > /etc/rc.d directly. I have no idea what might be the purpose of this
> > file but given that it is sourcing a non-existing file
> > /etc/rc.d/init.d/functions
> > its not working anyway. If this script has some actual use please
> > fix it.
> Yes. the glite-ce-blah-parser should be removed. Thank you for catching
> that.
I'Ve just removed the FIXME (and please thank lintian for catching that ;-P)
> > I'd also recommend to turn the csh script
> > src/condor_release/examples/sh_loop
> > into POSIX shell. There is absolutely no need to have this simple
> > script in csh.
As I said this should be done in the next upstream release.
> > Please see the now updated lintian issues[1].
You might like to check the new CI output soon since I pushed my changes.
Kind regards
Andreas.
> > [1] https://salsa.debian.org/hpc-team/condor/-/jobs/3455879
--
http://fam-tille.de
Reply to: