[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990862: infinipath-psm: reproducible builds: Embedded timestamps in libpsm_infinipath.so



On 2021-07-09, Vagrant Cascadian wrote:
> diff --git a/buildflags.mak b/buildflags.mak
> index 34fdf1c..3e25649 100644
> --- a/buildflags.mak
> +++ b/buildflags.mak
> @@ -96,3 +96,11 @@ endif
>  CFLAGS += $(BASECFLAGS) $(if $(filter $(CC),gcc),-Wno-strict-aliasing) \
>  	$(if $(PSM_VALGRIND:0=),-DPSM_VALGRIND,-DNVALGRIND)
>  
> +# Use SOURCE_DATE_EPOCH for build date, falling back to current time
> +# https://reproducible-builds.org/docs/source-date-epoch/
> +DATE_FMT="+'%F %R'"
> +ifdef FIXME_SOURCE_DATE_EPOCH

^^^ OopS! that was my debugging attempt to make sure it works when
SOURCE_DATE_EPOCH is not set.

It *should* be:

  ifdef SOURCE_DATE_EPOCH

> +    BUILD_DATE ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || date -u "$(DATE_FMT)")
> +else
> +    BUILD_DATE ?= $(shell date "$(DATE_FMT)")
> +endif

Will send updated patch...


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature


Reply to: