Bug#885759: Use /var/run as a statedir, and not /var/run/slurm-llnl

[Gennaro Oliva <oliva.g@na.icar.cnr.it>]

Hi Met,
thank you for this bug report.

On Fri, Mar 01, 2019 at 12:48:20AM +0100, nikt@sucha.eu wrote:
> What happened is that config files (slurm.conf, slurmdbd.conf) still
> contain pid paths in /run/slurm-llnl/. Note: not /var/run/slurm-llnl/ but
> /run/slurm-llnl in my case.

The intention was to modify the location specified in the
slurm-wlm-configurator.html and not every possible location. This
because for any reason you can keep your pid file elsewhere and create 
the service file accordingly as you did. Anyway, since /var/run is only
a symbolic link to /run I modified the post installation script to handle
also this option, as in your case, in the next package release.

> Hint: maybe a wrong regex to match paths? Maybe only /var/run but not /run
> is updated?

the last hypothesis was the right one.

> Since the pid is hardcoded in systemd unit configs, then imo it is better
> to remove the pid file entries altogether from slurm config files.

I don't think this is appropriate because, if a system administrator decide
to keep the pid file in another place and create a new service file
accordingly, removing the pid file entry in the configuration would make
services fail to start.

Best regards,
-- 
Gennaro Oliva