[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#900673: ibutils FTCBFS: abuses AC_CHECK_FILE



Source: ibutils
Version: 1.5.7+0.2.gbd7e502-1
Tags: patch upstream
User: helmutg@debian.org
Usertags: rebootstrap

ibutils fails to cross build from source, because it abuses
AC_CHECK_FILE to discover includes. AC_CHECK_FILE is meant for
discovering files on the host machine, but here it is being used for
discovering files on the build machine. A simple test -f is better and
makes ibutils cross buildable. Please consider applying the attached
patch.

Helmut
--- ibutils-1.5.7+0.2.gbd7e502.orig/ibis/config/osm.m4
+++ ibutils-1.5.7+0.2.gbd7e502/ibis/config/osm.m4
@@ -166,7 +166,7 @@
 
 
    dnl validate the defined path - so the build id header is there
-   AC_CHECK_FILE($osm_include_dir/opensm/osm_config.h,,
+   AS_IF([test -f "$osm_include_dir/opensm/osm_config.h"],,
       AC_MSG_ERROR([OSM: could not find $with_osm/include/opensm/osm_config.h]))
 
    dnl now figure out somehow if the build was for debug or not
--- ibutils-1.5.7+0.2.gbd7e502.orig/config/osm.m4
+++ ibutils-1.5.7+0.2.gbd7e502/config/osm.m4
@@ -166,7 +166,7 @@
 
 
    dnl validate the defined path - so the build id header is there
-   AC_CHECK_FILE($osm_include_dir/opensm/osm_config.h,,
+   AS_IF([test -f "$osm_include_dir/opensm/osm_config.h"],,
       AC_MSG_ERROR([OSM: could not find $with_osm/include/opensm/osm_config.h]))
 
    dnl now figure out somehow if the build was for debug or not
--- ibutils-1.5.7+0.2.gbd7e502.orig/ibmgtsim/config/osm.m4
+++ ibutils-1.5.7+0.2.gbd7e502/ibmgtsim/config/osm.m4
@@ -166,7 +166,7 @@
 
 
    dnl validate the defined path - so the build id header is there
-   AC_CHECK_FILE($osm_include_dir/opensm/osm_config.h,,
+   AS_IF([test -f "$osm_include_dir/opensm/osm_config.h"],,
       AC_MSG_ERROR([OSM: could not find $with_osm/include/opensm/osm_config.h]))
 
    dnl now figure out somehow if the build was for debug or not

Reply to: