Re: RFS: libpsm2
Hi Brian,
I looked at the package and have following remarks:
* Please move it from pkg-ofed/libpsm2.git to debian-hpc/libpsm2.git
since we want to give up pkg-ofed
* Please look into providing the appstream metadata. It looks useful:
$ lintian-info -t appstream-metadata-missing-modalias-provide
W: appstream-metadata-missing-modalias-provide
N:
N: This package contain a udev rule for providing device access to the
N: console user (using the uaccess udev TAG) or to members of the plugdev
N: file group without announcing the hardware support using AppStream.
N:
N: Refer to https://wiki.debian.org/AppStream/Guidelines for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: appstream-metadata, Type: binary
N:
* Please drop "Files-Excluded: debian/*" from debian/copyright. This is
not needed with the "3.0 (quilt)" format.
* use https for copyright format url
* there are some tabs in debian/copyright
* Please adjust the minimum version in debian/libpsm2-2.symbol - do
they really work with 10.3.0 or do they require 10.3.X?
Am Montag, den 18.12.2017, 15:14 -0600 schrieb Brian Smith:
> Hi Afif,
>
> Have you had a chance to give libpsm2 a closer look? I didn't want to
> make any changes until I got the full review.
>
> If you don't have time for this, I'll try Debian mentors.
>
> Thanks.
> Brian T. Smith
> System Fabric Works
> Senior Technical Staff
> bsmith@systemfabricworks.com
> (512) 293-4472
> GPG Key: B3C2C7B73BA3CD7F
>
>
> On Sat, Dec 16, 2017 at 12:38 AM, Afif Elghraoui <afif@debian.org>
> wrote:
> >
> >
> > على الخميس 14 كانون الأول 2017 00:57، كتب Brian Smith:
> > > Re: amd64 architecture
> > >
> > > libpsm2 may very well compile on freebsd-amd64. However, the
> > > freebsd
> > > kernel has no hfi1 module at this point in time. Lacking kernel
> > > support, this package will be useless on that architecture. Also,
> > > I
> > > believe that upstream has no intent to support freebsd. Thoughts?
> >
> > That's a good reason to keep it as is. :)
> >
> > regards
> > Afif
> >
> > --
> > Afif Elghraoui | عفيف الغراوي
> > http://afif.ghraoui.name
> >
>
>
--
Benjamin Drung
System Developer
Debian & Ubuntu Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Email: benjamin.drung@profitbricks.com
URL: https://www.profitbricks.de
Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg
Reply to: