[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1094174: RFS: showtime/47.0-1 [ITP] -- Watch without distraction



On Sun, 26 Jan 2025 12:33, Danial Behzadi <dani.behzi@ubuntu.com> wrote:

d/copyright:
Please add:

data/org.gnome.Showtime.metainfo.xml.in:
<metadata_license>CC0-1.0</metadata_license>

d/control:
Please change Maintainer to the GNOME team, and add yourself as uploader. Update the VCS-urls to point to the GNOME team repo.
.
Also, please depend on dh-sequence-python3 rather than python3.
d/gbp.conf:
Please update to match the teams' one
d/patches:
just a nitpick, but no need to add commit: before the hash
d/showtime.1:
This seems a bit redundant to me. GUI programs do not need a manpage.
If you want to include one I would at least add some description on what the program does.

I fixed these, pushed to the new repo and uploaded the new build to mentors.

Almost good for upload; one final small nitpick:
It should be python3:any in Depends.

best,

werdahias


Reply to: