Re: Announcement: packaging workflow changes
On 26/03/26 2:34 pm, Richard Hansen wrote:
> On 3/26/26 04:13, Andrew Lee wrote:
>> What? You merged all of them in a few hours
It might be sensible to restrict access to the policy repo to only owners
to prevent this in the future.
> No:
>
> * I opened MR #11 (the main MR) in October and merged it ~3 weeks
> ago. (If 5 months is not enough time for people to review then I don't
> know what is.)
The last wave of policy changes actually took 2 years including an in-person debconf
to finalize things.
If you don't get enough reviews, you should consider to nudge on this list.
> * I left MR #13 open for a couple of days before I merged it ~3 weeks
> ago. It was split off of #11, which had been open for 5 months, so I
> figured that gave people plenty of time to opine.
No.
> * MR #16 was open for ~2 weeks before I merged it yesterday.
2 weeks is very short, and there are no seconds.
> * MR #17 was a minor clarification that didn't really need review.
> * MR #18 added a changelog entry, not a policy/procedure change.
>
>> just only one team member approved.
>
> MR #11 was thumb-upped by 3 others (in addition to the approval). I
> don't know why they didn't just review the MR, but I took that as
> general approval.
>
> How many team members should approve changes? I think it's
> counterproductive to wait several days/weeks/months for approvals when
> it's easy to just revert a change and try again if someone has an objection.
No. It wastes more time and cycles, really. This happened last year in
https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/9
https://lists.debian.org/debian-devel/2024/08/msg00299.html
I support changing outdated things, and I do agree that speed of making decisions
is not exactly what I'd call as optimal here. But you ought to give more time.
Please listen to Andrew.
>> I don't even notice your merge requests exist.
>
> Can we configure Salsa to email debian-go whenever a MR is opened for
> the go-team.pages.debian.net project? Should we?
Unsure if configuring this is an option. But you could tag @go-team -- all go-team members
on salsa would get a notification that way and would probably lead to more reviews.
>> On Thu, Mar 26, 2026 at 7:41 AM Richard Hansen <rhansen@rhansen.org> wrote:
>>> dh-make-golang does not follow these best practices when generating a
>>> new package (manual tweaks are often required); I will be working on
>>> that next. Despite this, most packages already conform. I haven't done
>>> an exhaustive survey, but I plan on adding some warnings to
>>> dh-make-golang and/or lintian to make it easier to find packages that
>>> don't follow these best practices. Don't feel obligated to update any
>>> existing packages to conform; if they work now, they should continue to
>>> work with the changes I plan to make.
Lintian maintainer here. What changes in particular are you planning?
Best,
Nilesh
Reply to: