[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

seeking review of pat 0.19.2



Hello debian-hams and tmancill --

I've packaged pat v0.19.2 and pushed my work to salsa.d.o .

     https://tracker.debian.org/pkg/pat

This upgrade looks relatively minor, with some upstream bug fixes.  I've also
included "Recommends: voacapl" which upstream has supported since v0.19 and
provides HF propagation prediction support.

Some questions I had during review and packaging include:

a) Upstream has changed their "build process" to package their web asset
   pipeline, now using docker -- run from the `make.bash' script.  

   I'm 95% sure we (debian) are not using this script or that build process,
   and also that this approach/effort is not required for us.

   My understanding is we're using their already "packaged" web asset
   (node.js) files.

   Review and feedback would be welcome, in case I'm in error or misguided.

    https://github.com/la5nta/pat/commit/d7890d96dee359cc5ac06002e067d23231514911

b) Related to the above Q, this release has a big web node.js update...
   effectively a "blob"... 

   I attempted to scan the "blob" delta, but it is not very user-legible code.
   My inclination is to proceed with the change, accepting good faith by
   upstream (admittedly, not the most solid position).  Similarly, I'm not
   clear from the blob delta, if licensing changes are required (d/copyright).

   I very much welcome review and feedback if possible.

    https://github.com/la5nta/pat/commit/cdf4beb8fd41829761b084ce08149b54e68152a1


After review and feedback of the above items, if there are no blocking items I
welcome an upload of `pat' to unstable for additional testing, or alternate
constructive guidance.


Regards,
donfede

Fede Grau


Attachment: signature.asc
Description: PGP signature


Reply to: