Vincent Blut <vincent.debian@free.fr> writes:
> Hi Simon,
>
> Le 2026-02-10 00:02, Vincent Blut a écrit :
>> Le 2026-02-06 22:57, Simon Josefsson a écrit :
>> > Vincent Blut <vincent.debian@free.fr> writes:
>> >
>> > > Would someone in the team be willing to review this new package?
>> > >
>> > > https://salsa.debian.org/go-team/packages/golang-github-jezek-xgb
>> >
>> > Looks good to me. Some nitpicks:
>> >
>> > I think you want to add the names from AUTHORS to debian/copyright since
>> > it claims they are authors for copyright purposes.
>>
>> *nod*
>>
>> Listing them individually is definitely more appropriate than the
>> current "The XGB Authors" copyright notice.
>
> This is now fixed in git. In addition to this change, I excluded the
> xgbgen tool from the build target since the bindings are pre-built and I also
> imported the last upstream version which contain a single bug fix.
Looks good to me! Are you looking for a sponsor, or just review?
The '2017-2025 jEzEk' line does not seem to correspond to any copyright
notice in the source code though, not sure why you added it? Copyright
laws doesn't require explicit notices in many places, so in theory maybe
you should mention all commiters (see below). OTOH, I've never seen
anyone suggest or do this in Debian though, and I think the policy is to
only duplicate the actual copyright notices from the upstream source
code (and explicit references to copyright holders as in AUTHORS), nut
not mention anyone based only on git commit information. This seems a
bit fishy from a legal perspective though.
Copyright: 2012 Andrew Gallant (Ocelot) <Andrew.Gallant@tufts.edu> (58 commits)
2012 Paul Sbarra <Sbarra.Paul@gmail.com> (1 commit)
2012-2021 Andrew Gallant <jamslam@gmail.com> (27 commits)
2013 Axel Wagner <mail@merovius.de> (1 commit)
2013 snyh <snyh@snyh.org> (2 commits)
2014-2016 aarzilli <alessandro.arzilli@gmail.com> (4 commits)
2015 fangyuanziti <tiziyuanfang@gmail.com> (1 commit)
2014 Bryan Matsuo <bryan.matsuo@gmail.com> (1 commit)
2016 Rabin Vincent <rabin@rab.in> (1 commit)
2017-2026 jEzEk <jezek@chicki.sk> (40 commits)
2020 Jvol Jvolizka <damnedprotoss@gmail.com> (1 commit)
2020-2026 Andy Williams <andy@andy.xyz> (8 commits)
2021 scrouthtv <lennivh24@gmail.com> (1 commit)
2021 Lenni <lennivh24@gmail.com> (24 commits)
2022 woofdoggo <woofwoofdoggo@protonmail.com> (2 commits)
2022 Alessandro Arzilli <alessandro.arzilli@gmail.com> (1 commit)
2022 Milan Nikolic <gen2brain@gmail.com> (1 commit)
2023 Dimitri Sokolyuk <sokolyuk@gmail.com> (1 commit)
2025 Ali Mohit <ali.mohit.sbu@gmail.com> (5 commits)
/Simon
Attachment:
signature.asc
Description: PGP signature